Michael-J-Ward commented on code in PR #880:
URL: https://github.com/apache/datafusion-python/pull/880#discussion_r1777657146
##########
python/datafusion/udf.py:
##########
@@ -246,3 +246,229 @@ def udaf(
state_type=state_type,
volatility=volatility,
)
+
+
+class WindowEvaluator(metaclass=ABCMeta):
+ """Evaluator class for user defined window functions (UDWF).
+
+ It is up to the user to decide which evaluate function is appropriate.
+
+
|``uses_window_frame``|``supports_bounded_execution``|``include_rank``|function_to_implement|
+ |---|---|----|----|
+ |False (default) |False (default) |False (default) |
``evaluate_all`` |
+ |False |True |False |
``evaluate`` |
+ |False |True/False |True |
``evaluate_all_with_rank`` |
+ |True |True/False |True/False |
``evaluate`` |
Review Comment:
Does the table render properly for you? I had to update to this suggestion
in order for the table to render properly.
```suggestion
+------------------------+--------------------------------+------------------+---------------------------+
| ``uses_window_frame`` | ``supports_bounded_execution`` |
``include_rank`` | function_to_implement |
+========================+================================+==================+===========================+
| False (default) | False (default) | False
(default) | ``evaluate_all`` |
+------------------------+--------------------------------+------------------+---------------------------+
| False | True | False
| ``evaluate`` |
+------------------------+--------------------------------+------------------+---------------------------+
| False | True/False | True
| ``evaluate_all_with_rank``|
+------------------------+--------------------------------+------------------+---------------------------+
| True | True/False | True/False
| ``evaluate`` |
+------------------------+--------------------------------+------------------+---------------------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
