alamb commented on code in PR #12654:
URL: https://github.com/apache/datafusion/pull/12654#discussion_r1779295758
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -291,10 +291,7 @@ pub(crate) fn parse_identifiers(s: &str) ->
Result<Vec<Ident>> {
}
/// Construct a new [`Vec`] of [`ArrayRef`] from the rows of the `arrays` at
the `indices`.
-pub fn get_arrayref_at_indices(
- arrays: &[ArrayRef],
- indices: &PrimitiveArray<UInt32Type>,
-) -> Result<Vec<ArrayRef>> {
+pub fn take_arrays(arrays: &[ArrayRef], indices: &dyn Array) ->
Result<Vec<ArrayRef>> {
Review Comment:
I think it makes sense to move to arrow. And maybe add a not int he docs for
`RecordBatch` pointing people at it
It is common enough that it would be nice not to have to write it in each
downstream crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
