jcsherin commented on PR #12662: URL: https://github.com/apache/datafusion/pull/12662#issuecomment-2380851014
> One thing I noticed is that there are no tests for this functionality (as in if we removed / broke the code no tests would fail). Is the idea that it will be test coverage added when we port some of the built in window functions? Yes, this situation is temporary. When one of the built-in window functions like `lead`, `lag`, `nth_value` etc. are converted this API path will get tested by existing sqllogictests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
