andygrove commented on code in PR #1000:
URL: https://github.com/apache/datafusion-comet/pull/1000#discussion_r1792138764
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -1105,7 +1105,8 @@ object CometSparkSessionExtensions extends Logging {
try {
// This will load the Comet native lib on demand, and if success, should
set
// `NativeBase.loaded` to true
- NativeBase.isLoaded
+ NativeBase.load()
Review Comment:
The goal of this PR was to remove the static initializer and explicitly load
the native library so that we can catch exceptions and report them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
