Rachelint commented on PR #12667: URL: https://github.com/apache/datafusion/pull/12667#issuecomment-2400592077
@alamb I have added tests to cover more aggregations: - basic prim aggr(sum/sum distinct/max/min/count/avg) - basic string aggr(count/count distinct/min/max) I make it through the simpel implementation about randomly select sql memtioned in https://github.com/apache/datafusion/pull/12667#issuecomment-2399675682 - it will randomly select a sql for each dataset - then run `CTX_GEN_ROUNDS(now 16)` randomly `SessionConfig` on specific `dataset + selected query` Now the testcase may be like: ``` // Build fuzzer let fuzzer = builder .data_gen_config(data_gen_config) .data_gen_rounds(16) .add_sql("SELECT sum(a) FROM fuzz_table") .add_sql("SELECT sum(distinct a) FROM fuzz_table") .add_sql("SELECT max(a) FROM fuzz_table") .add_sql("SELECT min(a) FROM fuzz_table") .add_sql("SELECT count(a) FROM fuzz_table") .add_sql("SELECT count(distinct a) FROM fuzz_table") .add_sql("SELECT avg(a) FROM fuzz_table") .table_name("fuzz_table") .build(); ``` And unforunately, seems a new bug about `min/max` for string found... Maybe we to check and try to fix it in other pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
