notfilippo commented on code in PR #12793:
URL: https://github.com/apache/datafusion/pull/12793#discussion_r1793368715
##########
datafusion/expr-common/src/scalar.rs:
##########
@@ -76,6 +79,30 @@ impl PartialEq for Scalar {
}
}
+impl PartialOrd for Scalar {
+ fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
+ self.value.partial_cmp(&other.value)
+ }
+}
+
+impl Hash for Scalar {
+ fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
+ self.value.hash(state);
+ }
+}
+
+impl fmt::Display for Scalar {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ self.value.fmt(f)
+ }
+}
+
+impl fmt::Debug for Scalar {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ self.value.fmt(f)
Review Comment:
This is me being lazy since some tests were failing because they compare
debug prints of plans. I can revert this, it was added to not introduce other
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
