adriangb commented on code in PR #12835: URL: https://github.com/apache/datafusion/pull/12835#discussion_r1793869081
########## datafusion/core/src/physical_optimizer/pruning.rs: ########## @@ -1315,24 +1351,23 @@ const MAX_LIST_VALUE_SIZE_REWRITE: usize = 20; /// Translate logical filter expression into pruning predicate /// expression that will evaluate to FALSE if it can be determined no /// rows between the min/max values could pass the predicates. +/// +/// Any predicates that can not be translated will be passed to `unhandled_hook`. /// /// Returns the pruning predicate as an [`PhysicalExpr`] /// -/// Notice: Does not handle [`phys_expr::InListExpr`] greater than 20, which will be rewritten to TRUE -fn build_predicate_expression( +/// Notice: Does not handle [`phys_expr::InListExpr`] greater than 20, which will fall back to calling `unhandled_hook` +pub fn build_predicate_expression( Review Comment: I'm open to new names. We could also make a wrapper that e.g. does not require `required_columns` and takes `Option<UnhandledPredicateHook>` which defaults to `true`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
