alamb commented on code in PR #12832:
URL: https://github.com/apache/datafusion/pull/12832#discussion_r1793874972
##########
datafusion/core/tests/fuzz_cases/aggregation_fuzzer/fuzzer.rs:
##########
@@ -132,7 +133,17 @@ struct QueryGroup {
}
impl AggregationFuzzer {
+ /// Run the fuzzer, printing an error and panicking if any of the tasks
fail
pub async fn run(&self) {
+ let res = self.run_inner().await;
+
+ if let Err(e) = res {
+ println!("{e}");
Review Comment:
Without that block the error is printed with embedded newlines (so like
"Error\nfoo\nbar\n..") which is hard to understand.
I will make the rationale clear with a comment
```suggestion
// Print the error via `Display` so that it displays nicely (the
default `unwrap()`
// prints using `Debug` which escapes newlines, and makes
multi-line messages
// hard to read
println!("{e}");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
