kazuyukitanimura commented on PR #1001: URL: https://github.com/apache/datafusion-comet/pull/1001#issuecomment-2404186717
Confirmed it was about adding structure support. Opened https://github.com/apache/datafusion/issues/12843 Ideal to fix it before the next release, otherwise it is a regression. @jayzhan211 @alamb For this specific test case to pass, I just needed to add ``` .or_else(|| struct_coercion(lhs_type, rhs_type)) ``` at the end of `type_union_resolution_coercion`. Dictionary is fine, it seems to be working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
