berkaysynnada opened a new pull request, #12876:
URL: https://github.com/apache/datafusion/pull/12876
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The `MemTable` contains a field `sort_order:
Arc<Mutex<Vec<Vec<SortExpr>>>>`, and its columns refer to the original schema
of the source. In the `scan()` method, we introduce an optional projection that
is injected into `MemoryExec`. However, currently, the `sort_order` is not
projected, which results in it referring to an invalid schema during planning.
I am surprised that existing tests do not catch this problem. I identified
this bug in our downstream tests, where newly added aggregate fuzzer tests
exposed the problem. For instance, the test
`test_basic_prim_aggr_group_by_mixed_string_int64()` have queries that do not
use column "d," but `sort_keys_set` contains an ordering involving "d". If we
had supported ordered `MemoryExec` via sql (e.g., CREATE TABLE ... WITH ORDER
...), this problem would likely have surfaced earlier. Currently, we can only
set the order of a `MemTable` using `with_sort_order()`, and that's what these
tests do. They assign an order to a `MemTable`, but this order is not used
either in the query result or in an intermediate step.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Before constructing a `MemoryExec`, its sort expressions are projected using
the equivalence projection API.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
I have added an assertion at the start of the order assignment in
`MemoryExec`. If any column in the sort expressions does not appear in the
schema, it throws an error.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
