alamb commented on PR #12767: URL: https://github.com/apache/datafusion/pull/12767#issuecomment-2407580126
> > @berkaysynnada I wonder if you have some time for a review of this PR? > > For sure but as I mentioned [here](https://github.com/apache/datafusion/issues/12700#issuecomment-2399036407), I’ve discovered a tricky bug in both the `satisfy()` and `add_ordering()` APIs. I've completed half of the fix so far. I would suggest holding off on this PR until that is resolved, as some of the existing tests will be improved. Once that PR is merged, we can update this PR with a more solid and accurate equivalence mechanism. Cool -- sounds good Note this is only a change to move some tests. We can wait until your fix for satisfy/ordering I didn't realize you had found a bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
