alamb commented on code in PR #12883:
URL: https://github.com/apache/datafusion/pull/12883#discussion_r1797494363
##########
datafusion/sqllogictest/test_files/group_by.slt:
##########
@@ -5207,4 +5207,67 @@ NULL NULL 2
NULL a 2
statement ok
-drop table t;
+drop table t
Review Comment:
here are some end to end tests (maybe we just need to extend them for binary)
##########
datafusion/physical-plan/src/aggregates/group_values/group_column.rs:
##########
@@ -579,4 +897,153 @@ mod tests {
assert!(!builder.equal_to(4, &input_array, 4));
assert!(builder.equal_to(5, &input_array, 5));
}
+
+ #[test]
Review Comment:
perhaps these tests would be helpful @Rachelint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
