jonahgao commented on code in PR #12561:
URL: https://github.com/apache/datafusion/pull/12561#discussion_r1797613425


##########
datafusion/sqllogictest/test_files/create_external_table.slt:
##########
@@ -102,8 +102,11 @@ CREATE TEMPORARY TABLE my_temp_table (
     name TEXT NOT NULL
 );
 
+statement ok
+CREATE EXTERNAL TABLE ttemp STORED AS parquet LOCATION 
'../../parquet-testing/data/alltypes_plain.parquet' WITH ORDER (id);

Review Comment:
   ```sh
   CREATE TEMPORARY VIEW my_temp_view AS SELECT id FROM ttemp;
   ```
   I think this test is a duplication of `CREATE TEMPORARY VIEW y AS VALUES 
(1,2,3)` in ddl.slt. 
   Maybe we can remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to