jcsherin commented on code in PR #12857:
URL: https://github.com/apache/datafusion/pull/12857#discussion_r1797735004
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -286,10 +284,7 @@ pub fn parse_expr(
.map_err(|_| Error::unknown("BuiltInWindowFunction",
*i))?
.into();
- let args =
- parse_optional_expr(expr.expr.as_deref(), registry,
codec)?
- .map(|e| vec![e])
- .unwrap_or_else(Vec::new);
+ let args = parse_exprs(&expr.exprs, registry, codec)?;
Review Comment:
Parse all arguments instead of parsing only the first argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
