findepi commented on code in PR #12885:
URL: https://github.com/apache/datafusion/pull/12885#discussion_r1797767527
##########
benchmarks/src/bin/h2o.rs:
##########
@@ -26,7 +26,7 @@ use datafusion::datasource::listing::{
use datafusion::datasource::MemTable;
use datafusion::prelude::CsvReadOptions;
use datafusion::{arrow::util::pretty, error::Result, prelude::SessionContext};
-use datafusion_benchmarks::BenchmarkRun;
+use datafusion_benchmarks::util::BenchmarkRun;
Review Comment:
i think the real problem (if any) is that
`datafusion_benchmarks::BenchmarkRun` and
`datafusion_benchmarks::util::BenchmarkRun` are both valid import path.
there are 3 ways to go about it
- stop re-exporting BenchmarkRun from crate root, require `::util::`
- make util private, accept only BenchmarkRun import from crate root
- ignore the problem and give up on consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
