2010YOUY01 commented on code in PR #12888:
URL: https://github.com/apache/datafusion/pull/12888#discussion_r1798425953
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -102,6 +102,19 @@ struct SpillState {
/// true when streaming merge is in progress
is_stream_merging: bool,
+
+ // ========================================================================
+ // METRICS:
+ // ========================================================================
+ /// Peak memory used for buffered data.
+ /// Calculated as sum of peak memory values across partitions
+ peak_mem_used: metrics::Gauge,
+ /// count of spill files during the execution of the operator
+ spill_count: metrics::Count,
Review Comment:
We should also keep the name consistent in other operators, I am thinking
about a related refactor, so I can do this in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
