lovasoa commented on code in PR #1474:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1474#discussion_r1798561445
##########
src/parser/mod.rs:
##########
@@ -9416,27 +9416,42 @@ impl<'a> Parser<'a> {
}
}
+ fn parse_set_role(&mut self, modifier: Option<Keyword>) ->
Option<Statement> {
Review Comment:
parse_identifier cannot return an error here (because of the checks above).
But you are right, maybe_parse is both more robust and more readable. I changed
the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
