findepi commented on code in PR #12853: URL: https://github.com/apache/datafusion/pull/12853#discussion_r1798841086
########## datafusion/common/src/types/logical.rs: ########## @@ -0,0 +1,41 @@ +use core::fmt; +use std::{cmp::Ordering, hash::Hash, sync::Arc}; + +use super::NativeType; + +/// A reference counted [`LogicalType`] +pub type LogicalTypeRef = Arc<dyn LogicalType>; + +pub trait LogicalType: fmt::Debug { + fn native(&self) -> &NativeType; + fn name(&self) -> Option<&str>; Review Comment: A more structured approach will be needed if we want to reasonably serialize generic types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org