jonahgao commented on code in PR #12922:
URL: https://github.com/apache/datafusion/pull/12922#discussion_r1801303443
##########
datafusion/functions/src/macros.rs:
##########
@@ -226,9 +226,8 @@ macro_rules! make_math_unary_udf {
$EVALUATE_BOUNDS(inputs)
}
- fn invoke(&self, args: &[ColumnarValue]) ->
Result<ColumnarValue> {
- let args = ColumnarValue::values_to_arrays(args)?;
-
+ fn invoke(&self, col_args: &[ColumnarValue]) ->
Result<ColumnarValue> {
Review Comment:
My thought is to add a new method, `fn maintains_scalar() -> bool`, to the
`ScalarUDFImpl` trait, which by default returns false, with some math functions
returning true. Or add such a flag in `Signature`. Check such a flag and apply
similar processing as in this PR to all functions in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
