findepi commented on code in PR #12943:
URL: https://github.com/apache/datafusion/pull/12943#discussion_r1801321137
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -685,7 +685,8 @@ impl OptimizerRule for PushDownFilter {
.map(LogicalPlan::Filter)?;
insert_below(LogicalPlan::Repartition(repartition), new_filter)
}
- LogicalPlan::Distinct(distinct) => {
+ LogicalPlan::Distinct(distinct @ Distinct::All(_)) => {
+ // note that we check for distinct all as distinct on is not
commutable
Review Comment:
Unless the filter is only on the distinct columns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
