findepi commented on code in PR #12916:
URL: https://github.com/apache/datafusion/pull/12916#discussion_r1801346825
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -282,6 +288,10 @@ impl Dialect for MySqlDialect {
ast::DataType::Custom(ObjectName(vec![Ident::new("SIGNED")]), vec![])
}
+ fn int32_cast_dtype(&self) -> ast::DataType {
+ ast::DataType::Custom(ObjectName(vec![Ident::new("SIGNED")]), vec![])
Review Comment:
MySQL integer is signed by default
Also where do we specify it's integer and not eg bigint or tinyint?
https://dev.mysql.com/doc/refman/8.4/en/integer-types.html
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -282,6 +288,10 @@ impl Dialect for MySqlDialect {
ast::DataType::Custom(ObjectName(vec![Ident::new("SIGNED")]), vec![])
}
+ fn int32_cast_dtype(&self) -> ast::DataType {
+ ast::DataType::Custom(ObjectName(vec![Ident::new("SIGNED")]), vec![])
Review Comment:
perhaps `SIGNED INTEGER` would work (it does in my MySQL)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
