tokoko commented on code in PR #12863:
URL: https://github.com/apache/datafusion/pull/12863#discussion_r1801386170
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -764,6 +768,7 @@ pub fn operator_to_name(op: Operator) -> &'static str {
}
}
+#[allow(deprecated)]
Review Comment:
I think so.. `grouping_expressions` field was deprecated in the proto
definitions, but should still be used for some time not to break
backwards-compatibility. Maybe there's some other way.. I just saw similar
deprecated markers and followed suit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
