blaginin commented on issue #9373: URL: https://github.com/apache/datafusion/issues/9373#issuecomment-2414664635
I believe there are two ways to fully resolve this issue: 1. Switch from the recursion to iteration like https://github.com/apache/datafusion/pull/6360 and https://github.com/apache/datafusion/pull/10023. To do this, we would need to store the nodes in a VecDeque or Vec and process them one by one. 3. Keep the recursion but use something like https://github.com/DelSkayn/reblessive. The downside is adding another dependency, but on the plus side, it will make fixing stack overflow bugs easier in the future. I will go with the first option, as suggested by @alamb, but I'm open to discussing this further if needed 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
