alamb commented on PR #1468: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1468#issuecomment-2414747574
> I have add `stacker` as optional dependency, so it won't be used in no std environment. > > *It will continue to stack overflow in this case. > > What's your opinion on the use of stacker? @alamb I think stacker is a clever hack but we should fix the code for real to avoid deeply nested callstacks rather than hoping that a third-party library will bail us out. I don't think it is a good idea to use `stacker` as I don't want to be responsible for trying to debug any issues caused by its use. That may sound selfish, but I am already at my cognitive complexity load for sqlparser (and various other crates) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
