alamb commented on code in PR #12847:
URL: https://github.com/apache/datafusion/pull/12847#discussion_r1801788647
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -45,299 +45,174 @@ use rand::{Rng, SeedableRng};
use tokio::task::JoinSet;
use crate::fuzz_cases::aggregation_fuzzer::{
- AggregationFuzzerBuilder, ColumnDescr, DatasetGeneratorConfig,
+ AggregationFuzzerBuilder, ColumnDescr, DatasetGeneratorConfig,
QueryBuilder,
};
// ========================================================================
// The new aggregation fuzz tests based on [`AggregationFuzzer`]
// ========================================================================
+//
+// Notes on tests:
+//
+// Since the supported types differ for each aggregation function, the tests
Review Comment:
This is my key observation -- if we structure the tests by aggregate
function I think that is mostly likely to permit the greatest coverage (as the
framework now varies queries, number of columns, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
