dhegberg opened a new pull request, #12961:
URL: https://github.com/apache/datafusion/pull/12961

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #10674.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   * On MacOS a batch size of 1,000,000 with a 10KB pool size results in a 
panic `Too many open files`.
   * The spill threshold for 10KB pool size already spills at the 20,000 batch 
size, so going to 1,000,000 for this test seem unnecessary.
   
   
   ## What changes are included in this PR?
   * change upper spill test threshold batch size to 500,000 from 1,000,000.
   * rename test to `test_sort_10k_mem` to reflect the 10KB pool size to be 
consistent with the test `test_sort_100k_mem` which uses a 100KB pool size.
   
   ## Are these changes tested?
   
   Changes are to tests.
   
   ## Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to