korowa commented on code in PR #12967:
URL: https://github.com/apache/datafusion/pull/12967#discussion_r1803484515
##########
datafusion/core/src/physical_optimizer/join_selection.rs:
##########
@@ -183,13 +183,15 @@ pub fn swap_hash_join(
partition_mode,
hash_join.null_equals_null(),
)?;
+ // if there is embeded projection in HashJoinExec, no need to add
projection again.
Review Comment:
```suggestion
// In case of anti / semi joins or if there is embedded projection in
HashJoinExec, output column order is preserved, no need to add projection again
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
