tokoko opened a new pull request, #12987: URL: https://github.com/apache/datafusion/pull/12987
## Rationale for this change Current roundtrip tests for wildcard expression pass only because tests themselves optimize the plan beforehand and "optimize" the wildcard away before actually doing a roundtrip. Producer should be able to convert the plan to substrait even if the plan isn't optimized beforehand. ## What changes are included in this PR? - Changes the wildcard test not to optimize the query beforehand - Injects `ExpandWildcardRule` at the top of the producer. Substrait doesn't have anything analogous to the wildcard, so the easiest solution I found was to run ExpandWildcardRule to work around that. The main thing is that it's run as part of the producer so the producer no longer assumes that full optimizer has been run before. ## Are these changes tested? yes ## Are there any user-facing changes? yes, producer can convert wildcard expression independently of the optimizer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
