jcsherin commented on PR #12857: URL: https://github.com/apache/datafusion/pull/12857#issuecomment-2420012516
1. Port the bug fix for handling `NULL` input in https://github.com/apache/datafusion/pull/12857/commits/814a9b7ec3d5460bf927ac80e6c5cddb61b5aea1. Made it into a single commit to make it easier to see the isolated diff for the bug fix. 2. Added a few more test cases in https://github.com/apache/datafusion/pull/12857/commits/c4b884098810997e21c1d683a9e3ca4dba2b397f 3. Added `WindowUDFImpl::expressions`. It has a default implementation so does not break existing user-defined window function implementations. @alamb This is ready for review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
