alamb commented on code in PR #12950:
URL: https://github.com/apache/datafusion/pull/12950#discussion_r1805424245


##########
datafusion/core/benches/physical_plan.rs:
##########
@@ -183,5 +187,67 @@ fn criterion_benchmark(c: &mut Criterion) {
     }
 }
 
-criterion_group!(benches, criterion_benchmark);
+/// Aimed at tracking inefficiencies at the stage of creating/optimizing a 
physical plan.
+fn bench_creation_many_columns(c: &mut Criterion) {

Review Comment:
   Could you please move this benchmark to the planning benchmark (where it 
will be easier to discover?)
   
   
https://github.com/apache/datafusion/blob/main/datafusion/core/benches/sql_planner.rs
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to