buraksenn commented on PR #12972: URL: https://github.com/apache/datafusion/pull/12972#issuecomment-2422349035
> LGTM, thank you @buraksenn. I wonder how CI passed before the [last commit](https://github.com/apache/datafusion/pull/12972/commits/58d3d86c793a119804a1322d75eb9c3607a64df2) 🤔 Thanks for reviewing the PR. The reason was that in a few lines above: ``` let mut x = &args[0]; ``` Thus using args[0] did not cause any errors but of course not a best practice afais. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
