findepi commented on PR #12953: URL: https://github.com/apache/datafusion/pull/12953#issuecomment-2421873744
thanks for review @goldmedal and the merge @alamb ! > I wonder how far we are from being able to remove the dependency entirely: > > [datafusion/datafusion/common/Cargo.toml](https://github.com/apache/datafusion/blob/44127ec96d7f2be2200af03ad65a2af1b8340b0a/datafusion/common/Cargo.toml#L65) That's a good question. Actually this is where i'd like to get to eventually. It should be possible to use datafusion without pulling sqlparser-rs dependency, which anyone with their own grammar should not use. There is couple places where this is used. - `DataFusionError::SQL` -- this can be put behind a feature cfg, or maybe we add some dyn trait to `DataFusionError` to allow for dynamic binding - identifiers: - `Column::from_qualified_name_ignore_case` - `Column::from_qualified_name` - `TableReference::parse_str` @alamb what would you suggest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
