iffyio commented on code in PR #1472:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1472#discussion_r1807180344
##########
src/dialect/mod.rs:
##########
@@ -561,6 +561,11 @@ pub trait Dialect: Debug + Any {
fn supports_asc_desc_in_column_definition(&self) -> bool {
false
}
+
+ /// Returns true if the dialect supports `a!` expressions
+ fn supports_factorial_operator(&self) -> bool {
+ false
+ }
Review Comment:
Actually I think we can ignore this comment and leave as is, the other
dialects will currently parse factorial but its not necessarily desirable (as
far as i can tell, among the supported dialects pg is the only one and the
syntax is deprecated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
