peasee commented on PR #12994: URL: https://github.com/apache/datafusion/pull/12994#issuecomment-2425479967
> > > @goldmedal perhaps you would like to merge this PR as a way to verify your permissions are configured correctly? > > > > > > Sure, I plan to merge this PR if no more comments tomorrow. > > Let's hold off on merging this for now. I think I've introduced a regression that I'd like to test more first before merging. Okay, looks like my PR didn't introduce the regression but there's a somewhat related bug currently on `main`. Take the following SQL: ``` SELECT j1_id FROM (SELECT ta.j1_id AS j1_id FROM j1 ta); ``` This gets rewritten in the `GenericDialect` to: ``` SELECT ta.j1_id FROM (SELECT ta.j1_id FROM j1 AS ta) ``` Which is invalid, because the subquery is un-aliased. I tested it in DuckDB to confirm: ``` D SELECT ta.j1_id FROM (SELECT ta.j1_id FROM j1 ta); Binder Error: Referenced table "ta" not found! Candidate tables: "unnamed_subquery" LINE 1: SELECT ta.j1_id FROM (SELECT ta.j1_id FROM j1 ... ``` Let's merge my PR, and I can raise a new issue for this other bug @goldmedal ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
