my-vegetable-has-exploded commented on code in PR #13022:
URL: https://github.com/apache/datafusion/pull/13022#discussion_r1808202057
##########
datafusion/core/src/physical_optimizer/join_selection.rs:
##########
@@ -1289,27 +1302,59 @@ mod tests_statistical {
);
}
+ #[rstest(
+ join_type, projection, small_on_right,
+ case::inner(JoinType::Inner, vec![1], true),
+ case::left(JoinType::Left, vec![1], true),
+ case::right(JoinType::Right, vec![1], true),
+ case::full(JoinType::Full, vec![1], true),
+ case::left_anti(JoinType::LeftAnti, vec![0], false),
Review Comment:
I think it will be better to add a swap test for LeftAnti & LeftSemi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
