eejbyfeldt opened a new pull request, #13032:
URL: https://github.com/apache/datafusion/pull/13032
## Which issue does this PR close?
Closes #13031
## Rationale for this change
The rational for moving the logic in to the SimplifyExpression is that is
allows the rule to better interact with other simplifications and also be
applied to all logical nodes, not just filters as the current rule is.
The reason for changing the logic is to only only rewrite the Expr when the
rule acutally applies. The current code will always change the current
structure of the expression which makes our optimizer harded to predict and
more sensitive to changes in the order the rules are applied.
The new code is also significantly shorter and at least to me easier to
follow.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Adding a rule in SimplifyExpressions that will extract common conjuntive
predicates in disjuntive predicates and removal of the existing rule
RewriteDisjuntivePredicate.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes, existing and new tests.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
Yes, the rule RewriteDisjuntivePredicate no longer exists.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
