findepi commented on code in PR #13033:
URL: https://github.com/apache/datafusion/pull/13033#discussion_r1808773273
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -1068,6 +1075,125 @@ mod tests {
fn use_execution_plan_as_trait_object(plan: &dyn ExecutionPlan) {
let _ = plan.name();
}
-}
-// pub mod test;
+ #[test]
+ fn test_check_not_null_constraints_accept_non_null() -> Result<()> {
+ check_not_null_constraints(
+ RecordBatch::try_new(
+ Arc::new(Schema::new(vec![Field::new("a", DataType::Int32,
true)])),
+ vec![Arc::new(Int32Array::from(vec![Some(1), Some(2),
Some(3)]))],
+ )?,
+ &vec![0],
+ )?;
+ Ok(())
+ }
+
+ #[test]
+ fn test_check_not_null_constraints_reject_null() -> Result<()> {
+ let result = check_not_null_constraints(
+ RecordBatch::try_new(
+ Arc::new(Schema::new(vec![Field::new("a", DataType::Int32,
true)])),
+ vec![Arc::new(Int32Array::from(vec![Some(1), None, Some(3)]))],
+ )?,
+ &vec![0],
+ );
+ assert!(result.is_err());
+ assert_eq!(
+ result.err().unwrap().message().as_ref(),
+ "Invalid batch column at '0' has null but schema specifies
non-nullable"
+ );
+ Ok(())
+ }
+
+ #[test]
+ fn test_check_not_null_constraints_with_run_end_array() -> Result<()> {
+ // some null value inside REE array
+ let run_ends = Int32Array::from(vec![1, 2, 3, 4]);
+ let values = Int32Array::from(vec![Some(0), None, Some(1), None]);
+ let run_end_array = RunArray::try_new(&run_ends, &values)?;
+ let result = check_not_null_constraints(
+ RecordBatch::try_new(
+ Arc::new(Schema::new(vec![Field::new(
+ "a",
+ run_end_array.data_type().to_owned(),
+ true,
+ )])),
+ vec![Arc::new(run_end_array)],
+ )?,
+ &vec![0],
+ );
+ assert!(result.is_err());
+ assert_eq!(
+ result.err().unwrap().message().as_ref(),
+ "Invalid batch column at '0' has null but schema specifies
non-nullable"
+ );
+ Ok(())
+ }
+
+ #[test]
+ fn test_check_not_null_constraints_with_dictionary_array_with_null() ->
Result<()> {
+ let values = Arc::new(Int32Array::from(vec![Some(1), None, Some(3),
Some(4)]));
+ let keys = Int32Array::from(vec![0, 1, 2, 3]);
+ let dictionary = DictionaryArray::new(keys, values);
+ let result = check_not_null_constraints(
+ RecordBatch::try_new(
+ Arc::new(Schema::new(vec![Field::new(
+ "a",
+ dictionary.data_type().to_owned(),
+ true,
+ )])),
+ vec![Arc::new(dictionary)],
+ )?,
+ &vec![0],
+ );
+ assert!(result.is_err());
+ assert_eq!(
+ result.err().unwrap().message().as_ref(),
+ "Invalid batch column at '0' has null but schema specifies
non-nullable"
+ );
+ Ok(())
+ }
+
+ #[test]
+ fn test_check_not_null_constraints_with_dictionary_masking_null() ->
Result<()> {
+ // some null value marked out by dictionary array
+ let values = Arc::new(Int32Array::from(vec![
+ Some(1),
+ None, // this null value is masked by dictionary keys
+ Some(3),
+ Some(4),
+ ]));
+ let keys = Int32Array::from(vec![0, /*1,*/ 2, 3]);
+ let dictionary = DictionaryArray::new(keys, values);
+ check_not_null_constraints(
+ RecordBatch::try_new(
+ Arc::new(Schema::new(vec![Field::new(
+ "a",
+ dictionary.data_type().to_owned(),
+ true,
+ )])),
+ vec![Arc::new(dictionary)],
+ )?,
+ &vec![0],
+ )?;
+ Ok(())
+ }
+
+ #[test]
+ fn test_check_not_null_constraints_on_null_type() -> Result<()> {
+ // null value of Null type
+ let result = check_not_null_constraints(
+ RecordBatch::try_new(
+ Arc::new(Schema::new(vec![Field::new("a", DataType::Null,
true)])),
+ vec![Arc::new(NullArray::new(3))],
+ )?,
+ &vec![0],
+ );
+ assert!(result.is_err());
+ assert_eq!(
+ result.err().unwrap().message().as_ref(),
+ "Invalid batch column at '0' has null but schema specifies
non-nullable"
Review Comment:
These tests do not pass with RUST_BACKTRACE=1 (as enabled on CI). Will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
