comphead commented on code in PR #1027:
URL: https://github.com/apache/datafusion-comet/pull/1027#discussion_r1809089216
##########
common/src/main/scala/org/apache/comet/package.scala:
##########
@@ -39,60 +40,46 @@ package object comet {
* benchmarking software to provide the source revision and repository. In
addition, the build
* information is included to aid in future debugging efforts for releases.
*/
- private object CometBuildInfo {
+ private object CometBuildInfo extends Logging {
- val (
- cometVersion: String,
- cometBranch: String,
- cometRevision: String,
- cometBuildUserName: String,
- cometBuildUserEmail: String,
- cometRepoUrl: String,
- cometBuildTimestamp: String) = {
+ val props: Properties = {
+ val props = new Properties()
val resourceStream = Thread
.currentThread()
.getContextClassLoader
.getResourceAsStream("comet-git-info.properties")
Review Comment:
perhaps we can set `comet-git-info.properties` as a constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
