Dandandan commented on code in PR #13054: URL: https://github.com/apache/datafusion/pull/13054#discussion_r1810116130
########## datafusion/core/src/datasource/physical_plan/parquet/mod.rs: ########## @@ -711,10 +724,15 @@ impl DisplayAs for ParquetExec { ) }) .unwrap_or_default(); - + let dynamic_filter = + format!("dynamic_filter: {:?}", self.dynamic_filters); Review Comment: I think it's best to only write this if available. + Would be good to implement `Display` for `DynamicFilterInfo` as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org