notfilippo commented on code in PR #13059:
URL: https://github.com/apache/datafusion/pull/13059#discussion_r1810773165
##########
datafusion/sqllogictest/test_files/window.slt:
##########
@@ -2208,7 +2208,7 @@ physical_plan
01)ProjectionExec: expr=[sum1@0 as sum1, sum2@1 as sum2]
02)--SortExec: TopK(fetch=5), expr=[c9@2 ASC NULLS LAST],
preserve_partitioning=[false]
03)----ProjectionExec: expr=[sum(aggregate_test_100.c12) ORDER BY
[aggregate_test_100.c1 ASC NULLS LAST, aggregate_test_100.c2 ASC NULLS LAST]
GROUPS BETWEEN 1 PRECEDING AND 1 FOLLOWING@3 as sum1,
sum(aggregate_test_100.c12) ORDER BY [aggregate_test_100.c1 ASC NULLS LAST]
GROUPS BETWEEN 5 PRECEDING AND 3 PRECEDING@4 as sum2, c9@1 as c9]
-04)------BoundedWindowAggExec: wdw=[sum(aggregate_test_100.c12) ORDER BY
[aggregate_test_100.c1 ASC NULLS LAST] GROUPS BETWEEN 5 PRECEDING AND 3
PRECEDING: Ok(Field { name: "sum(aggregate_test_100.c12) ORDER BY
[aggregate_test_100.c1 ASC NULLS LAST] GROUPS BETWEEN 5 PRECEDING AND 3
PRECEDING", data_type: Float64, nullable: true, dict_id: 0, dict_is_ordered:
false, metadata: {} }), frame: WindowFrame { units: Groups, start_bound:
Preceding(UInt64(5)), end_bound: Preceding(UInt64(3)), is_causal: false }],
mode=[Sorted]
+04)------BoundedWindowAggExec: wdw=[sum(aggregate_test_100.c12) ORDER BY
[aggregate_test_100.c1 ASC NULLS LAST] GROUPS BETWEEN 5 PRECEDING AND 3
PRECEDING: Ok(Field { name: "sum(aggregate_test_100.c12) ORDER BY
[aggregate_test_100.c1 ASC NULLS LAST] GROUPS BETWEEN 5 PRECEDING AND 3
PRECEDING", data_type: Float64, nullable: true, dict_id: 0, dict_is_ordered:
false, metadata: {} }), frame: WindowFrame { units: Groups, start_bound:
Preceding(UInt64(5)), end_bound: Preceding(UInt64(3)), is_causal: true }],
mode=[Sorted]
Review Comment:
Yes! It's very nice to have a bit more correctness when parsing from SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
