eejbyfeldt commented on code in PR #13046:
URL: https://github.com/apache/datafusion/pull/13046#discussion_r1811199029
##########
datafusion/core/src/physical_optimizer/optimizer.rs:
##########
@@ -103,6 +103,10 @@ impl PhysicalOptimizer {
// replacing operators with fetching variants, or adding limits
// past operators that support limit pushdown.
Arc::new(LimitPushdown::new()),
+ // The EliminateCommonPhysicalSubExprs rule extracts common
physical
+ // subexpression trees into a `ProjectionExec` node under the
actual node to
+ // calculate the common values only once.
+ Arc::new(EliminateCommonPhysicalSubexprs::new()),
Review Comment:
Do you have any examples of where this rule does eliminations for a plan
that has been optimized by the corresponding logical rule?
Because if not it not clear to me why it should be part of the
default/recommended list of rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
