alamb commented on PR #13063: URL: https://github.com/apache/datafusion/pull/13063#issuecomment-2430094697
> Am I confused about the doc test being wrong? Or should we set up doc tests to run with CI? The doctest passes for me locally ```shell (venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test --doc -p datafusion -- schema_adapter ... running 1 test test datafusion/core/src/datasource/schema_adapter.rs - datasource::schema_adapter::DefaultSchemaAdapterFactory (line 144) ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 97 filtered out; finished in 1.23s ``` I am pretty sure that the CI runs the doc tests as well. Here is this newly added test running in this PR: https://github.com/apache/datafusion/actions/runs/11463343177/job/31897653058?pr=13063#step:5:921 However, your catch on the doc test is excellent and I will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
