alamb commented on code in PR #13053:
URL: https://github.com/apache/datafusion/pull/13053#discussion_r1811326941
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -1512,7 +1517,10 @@ impl SMJStream {
};
// Push the filtered batch which contains rows passing
join filter to the output
- if matches!(self.join_type, JoinType::Left |
JoinType::LeftSemi) {
+ if matches!(
+ self.join_type,
+ JoinType::Left | JoinType::LeftSemi | JoinType::Right
Review Comment:
Do we also have to handle
https://docs.rs/datafusion/latest/datafusion/common/enum.JoinType.html#variant.RightSemi
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
