alamb commented on code in PR #13068:
URL: https://github.com/apache/datafusion/pull/13068#discussion_r1811510836


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1014,14 +1014,21 @@ impl DefaultPhysicalPlanner {
                             })
                             .collect();
 
+                        let metadata: HashMap<_, _> = left_df_schema

Review Comment:
   this one we should be able to write a test for -- perhaps with a query with 
a JOIN in 
https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/metadata.slt



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to