jonathanc-n commented on issue #13011:
URL: https://github.com/apache/datafusion/issues/13011#issuecomment-2430468199

   I added the global flags for regexp_replace so it actually replaces all the 
matches:
   ```
   regexp_count_1000 string
                           time:   [4.7333 ms 4.7585 ms 4.7831 ms]
                           change: [-1.3314% -0.5013% +0.3281%] (p = 0.24 > 
0.05)
                           No change in performance detected.
   
   Benchmarking regexp_count_1000 utf8view: Collecting 100 samples in estimated 
5.1350 s (1
   regexp_count_1000 utf8view
                           time:   [4.7126 ms 4.7726 ms 4.8517 ms]
                           change: [-1.2727% +0.1796% +1.9213%] (p = 0.84 > 
0.05)
                           No change in performance detected.
   Found 2 outliers among 100 measurements (2.00%)
     2 (2.00%) high severe
   
   Benchmarking regexp_like_1000: Collecting 100 samples in estimated 5.1855 s 
(2400 iterat
   regexp_like_1000        time:   [2.1724 ms 2.1958 ms 2.2264 ms]
                           change: [-1.2309% -0.1167% +1.1757%] (p = 0.87 > 
0.05)
                           No change in performance detected.
   Found 10 outliers among 100 measurements (10.00%)
     2 (2.00%) high mild
     8 (8.00%) high severe
   
   Benchmarking regexp_match_1000: Collecting 100 samples in estimated 5.0246 s 
(2000 itera
   regexp_match_1000       time:   [2.5040 ms 2.5100 ms 2.5208 ms]
                           change: [-2.0363% -1.1304% -0.3542%] (p = 0.00 < 
0.05)
                           Change within noise threshold.
   Found 3 outliers among 100 measurements (3.00%)
     1 (1.00%) high mild
     2 (2.00%) high severe
   
   Benchmarking regexp_replace_1000: Collecting 100 samples in estimated 5.3076 
s (1700 ite
   regexp_replace_1000     time:   [3.0762 ms 3.0808 ms 3.0855 ms]
                           change: [-3.0060% -1.5322% -0.4700%] (p = 0.01 < 
0.05)
                           Change within noise threshold.
    ```
    
    There is definitely a change compared to the benchmark taken by 
@xinlifoobar however the count function is still marginally slower.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to