alamb commented on code in PR #13047:
URL: https://github.com/apache/datafusion/pull/13047#discussion_r1812487492
##########
datafusion/functions-nested/src/map.rs:
##########
@@ -238,7 +241,50 @@ impl ScalarUDFImpl for MapFunc {
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
make_map_batch(args)
}
+
+ fn documentation(&self) -> Option<&Documentation> {
+ Some(get_map_doc())
+ }
}
+
+static DOCUMENTATION: OnceLock<Documentation> = OnceLock::new();
+
+fn get_map_doc() -> &'static Documentation {
+ DOCUMENTATION.get_or_init(|| {
+ Documentation::builder()
+ .with_doc_section(DOC_SECTION_SPECIAL)
Review Comment:
Sorry for the confusion -- I think there are two distinct action items:
1. Migrate the documentation for `map` and related functions to a "Map
Functions" section
2. Create a new static page for "special functions" (different than Scalar
Functions) where we can put `unnest`
Perhaps we can turn this PR into the `map` and related functions in a "Map
Functions" section and make another PR to move the `unnest` docs to the new
page.
I am happy to help with either
Thanks again for your help @jonathanc-n and @Omega359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
