alamb commented on issue #12740:
URL: https://github.com/apache/datafusion/issues/12740#issuecomment-2431747603

   I think we are pretty close here
   
   After we merge these PRs from @jonathanc-n  and myself
   - https://github.com/apache/datafusion/pull/13069
   - https://github.com/apache/datafusion/pull/13047
   
   We then have:
   - [ ] https://github.com/apache/datafusion/issues/13021
   
   Then we have just a few more functions to document (`lead`, `lag`) and we 
can turn on a CI check to ensure all new functions are documented
   
   ```shell
   (venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ 
./dev/update_function_docs.sh
   /Users/andrewlamb/Software/datafusion
   Inserting header
   Running CLI and inserting aggregate function docs table
       Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s
        Running `target/debug/print_functions_docs aggregate`
   Running prettier
   docs/source/user-guide/sql/aggregate_functions_new.md 59ms
   'docs/source/user-guide/sql/aggregate_functions_new.md' successfully updated!
   Inserting header
   Running CLI and inserting scalar function docs table
       Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
        Running `target/debug/print_functions_docs scalar`
   INFO: The following functions do not have documentation:
     - map_values
     - map_keys
     - map
     - map_extract
   Running prettier
   docs/source/user-guide/sql/scalar_functions_new.md 208ms
   'docs/source/user-guide/sql/scalar_functions_new.md' successfully updated!
   Inserting header
   Running CLI and inserting window function docs table
       Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
        Running `target/debug/print_functions_docs window`
   INFO: The following functions do not have documentation:
     - lag
     - lead
   Running prettier
   docs/source/user-guide/sql/window_functions_new.md 26ms
   'docs/source/user-guide/sql/window_functions_new.md' successfully updated!
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to