tustvold opened a new issue, #1035: URL: https://github.com/apache/datafusion-comet/issues/1035
### Describe the bug It was brought to my attention in https://github.com/apache/arrow-rs/pull/6616 that comet is currently violating the [aliasing rules](https://doc.rust-lang.org/nomicon/aliasing.html) of the Rust compiler. In particular it is mutating memory without exclusive ownership. The docs on CometBuffer actually call out that the type is unsound - https://github.com/apache/datafusion-comet/blob/main/native/core/src/common/buffer.rs#L166. This is the underlying cause of https://github.com/apache/datafusion-comet/issues/1030, which is a relatively harmless manifestation of what is ultimately undefined behaviour. I debated filing this ticket, as I wasn't sure how it would be received, but I think it is a sufficiently critical vulnerability that should at the very least be tracked / documented. Ultimately CometBuffer is unsound, and there is a concrete example of this unsoundness leading to undefined behaviour in #1030. ### Steps to reproduce _No response_ ### Expected behavior _No response_ ### Additional context FYI @viirya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
