Re: [PR] perf: Cache jstrings during metrics collection [datafusion-comet]

[via GitHub]

andygrove commented on PR #1029:
URL: 
https://github.com/apache/datafusion-comet/pull/1029#issuecomment-2433790085

   I ran some benchmarks locally and confirmed a speedup:
   
   
![tpch_allqueries](https://github.com/user-attachments/assets/09db7e47-b494-46f6-ae1b-1f6e31a5292b)
   
   
![tpch_queries_speedup](https://github.com/user-attachments/assets/070d6a99-a937-4267-8fd8-d340d0e8bbca)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org