alamb commented on code in PR #13061:
URL: https://github.com/apache/datafusion/pull/13061#discussion_r1814042647


##########
datafusion/optimizer/Cargo.toml:
##########
@@ -41,6 +41,7 @@ async-trait = { workspace = true }
 chrono = { workspace = true }
 datafusion-common = { workspace = true, default-features = true }
 datafusion-expr = { workspace = true }
+datafusion-functions = { workspace = true }

Review Comment:
   I was suggest adding a method to 
https://docs.rs/datafusion/latest/datafusion/logical_expr/simplify/trait.SimplifyInfo.html
   
   However i can't quite figure out how to plumb it in without getting messy
   
   THe trick is that this rewrite is based on the semantcs of `starts_with` -- 
so I think logically it would need to live along side the implementation of 
`starts_with` because it depends on those semantics.
   
   And similarly, to do the rewrite in the pruning predicate we need something 
similar (somehow to provide a per function rewrite) 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to